Stupid bug

[devedit.git] / modules / Command.pm

diff --git a/modules/Command.pm b/modules/Command.pm
index 4e7e365fb409cf938df686984ae76f9eb6e37c08..abff136a112148aee637168242050a11a5b997e6 100644 (file)
--- a/modules/Command.pm
+++ b/modules/Command.pm
@@ -6,7 +6,7 @@ package Command;
 # Execute Dev-Editor's commands
 #
 # Author:        Patrick Canterino <patshaping@gmx.net>
 # Execute Dev-Editor's commands
 #
 # Author:        Patrick Canterino <patshaping@gmx.net>

-# Last modified: 2004-10-30
+# Last modified: 2004-11-09

 #
 
 use strict;
 #
 
 use strict;


@@ -97,8 +97,10 @@ sub exec_show($$)
  {
   # Create directory listing
 
  {
   # Create directory listing
 

+  return error($config->{'errors'}->{'no_dir_access'},upper_path($virtual)) unless(-r $physical && -x $physical);
+

   my $direntries = dir_read($physical);
   my $direntries = dir_read($physical);

-  return error($config->{'dir_read_failed'},upper_path($virtual),{DIR => '$virtual'}) unless($direntries);
+  return error($config->{'dir_read_failed'},upper_path($virtual),{DIR => $virtual}) unless($direntries);

 
   my $files = $direntries->{'files'};
   my $dirs  = $direntries->{'dirs'};
 
   my $files = $direntries->{'files'};
   my $dirs  = $direntries->{'dirs'};


@@ -125,9 +127,11 @@ sub exec_show($$)
 
   foreach my $dir(@$dirs)
   {
 
   foreach my $dir(@$dirs)
   {

-   my @stat      = stat($physical."/".$dir);
+   my $phys_path = $physical."/".$dir;

    my $virt_path = encode_entities($virtual.$dir."/");
 
    my $virt_path = encode_entities($virtual.$dir."/");
 

+   my @stat      = stat($phys_path);
+

    my $dtpl = new Template;
    $dtpl->read_file($config->{'templates'}->{'dirlist_dir'});
 
    my $dtpl = new Template;
    $dtpl->read_file($config->{'templates'}->{'dirlist_dir'});
 


@@ -136,7 +140,8 @@ sub exec_show($$)
    $dtpl->fillin("DATE",strftime($config->{'timeformat'},localtime($stat[9])));
    $dtpl->fillin("URL",equal_url($config->{'httproot'},$virt_path));
 
    $dtpl->fillin("DATE",strftime($config->{'timeformat'},localtime($stat[9])));
    $dtpl->fillin("URL",equal_url($config->{'httproot'},$virt_path));
 

-   $dtpl->parse_if_block("users",$users && -o $physical."/".$dir);
+   $dtpl->parse_if_block("readable",-r $phys_path && -x $phys_path);
+   $dtpl->parse_if_block("users",$users && -o $phys_path);

 
    $dirlist .= $dtpl->get_template;
   }
 
    $dirlist .= $dtpl->get_template;
   }


@@ -910,8 +915,6 @@ sub exec_about($$)
   # Dev-Editor is running on a system which allows users and groups
   # So we display the user and the group of our process
 
   # Dev-Editor is running on a system which allows users and groups
   # So we display the user and the group of our process
 

-  require POSIX;
-

   my $uid = POSIX::getuid;
   my $gid = POSIX::getgid;
 
   my $uid = POSIX::getuid;
   my $gid = POSIX::getgid;
 


@@ -926,6 +929,10 @@ sub exec_about($$)
 
   $tpl->fillin("USER",getpwuid($uid));
   $tpl->fillin("GROUP",getgrgid($gid));
 
   $tpl->fillin("USER",getpwuid($uid));
   $tpl->fillin("GROUP",getgrgid($gid));

+
+  # Process umask
+
+  $tpl->fillin("UMASK",sprintf("%04o",umask));

  }
  else
  {
  }
  else
  {