Small code cleaning

[devedit.git] / modules / Config / DevEdit.pm

diff --git a/modules/Config/DevEdit.pm b/modules/Config/DevEdit.pm
index 24b3fe1e6cb6cc03b95b921f4f471d0a3f743722..7402ff19361a15a0089e2b5491967067e214d36b 100644 (file)
--- a/modules/Config/DevEdit.pm
+++ b/modules/Config/DevEdit.pm
@@ -5,8 +5,8 @@ package Config::DevEdit;
 #
 # Read and parse the configuration files
 #
 #
 # Read and parse the configuration files
 #

-# Author:        Patrick Canterino <patshaping@gmx.net>
-# Last modified: 2004-10-28
+# Author:        Patrick Canterino <patrick@patshaping.de>
+# Last modified: 2005-01-06

 #
 
 use strict;
 #
 
 use strict;


@@ -24,7 +24,7 @@ use base qw(Exporter);
 #
 # Read the configuration files of Dev-Editor
 #
 #
 # Read the configuration files of Dev-Editor
 #

-# Params: Path to configuration file
+# Params: Path to main configuration file

 #
 # Return: Configuration (Hash Reference)
 
 #
 # Return: Configuration (Hash Reference)
 


@@ -53,17 +53,20 @@ sub parse_config($)
  my $file = shift;
  local *CF;
 
  my $file = shift;
  local *CF;
 

- open(CF,"<$file") or croak("Open $file: $!");
+ open(CF,'<'.$file) or croak("Open $file: $!");

  read(CF, my $data, -s $file);
  close(CF);
 
  my @lines  = split(/\015\012|\012|\015/,$data);
  my $config = {};
  read(CF, my $data, -s $file);
  close(CF);
 
  my @lines  = split(/\015\012|\012|\015/,$data);
  my $config = {};

+ my $count  = 0;

 
  foreach my $line(@lines)
  {
 
  foreach my $line(@lines)
  {

+  $count++;
+

   next if($line =~ /^\s*#/);
   next if($line =~ /^\s*#/);

-  next if($line !~ /^.+=.+$/);
+  next if($line !~ /^\s*\S+\s*=.*$/);

 
   my ($key,$value) = split(/=/,$line,2);
 
 
   my ($key,$value) = split(/=/,$line,2);
 


@@ -74,7 +77,7 @@ sub parse_config($)
   $value =~ s/^\s+//g;
   $value =~ s/\s+$//g;
 
   $value =~ s/^\s+//g;
   $value =~ s/\s+$//g;
 

-  croak "Double defined value '$key' in configuration file '$file'" if($config->{$key});
+  croak "Configuration option '$key' defined twice in line $count of configuration file '$file'" if($config->{$key});

 
   $config->{$key} = $value;
  }
 
   $config->{$key} = $value;
  }