If locking of the uselist file failed, get the template variables directly from

[devedit.git] / devedit.pl

diff --git a/devedit.pl b/devedit.pl
index cf4ea19734299faf00526f7441aead29e25edd71..94c9f0e968382051140e5add1be7d65a6e932344 100644 (file)
--- a/devedit.pl
+++ b/devedit.pl
@@ -1,12 +1,12 @@
 #!C:/Programme/Perl/bin/perl.exe -w
 
 #
-# Dev-Editor 2.0
+# Dev-Editor 2.2a
 #
 # Dev-Editor's main program
 #
-# Author:        Patrick Canterino <patshaping@gmx.net>
-# Last modified: 2004-10-04
+# Author:        Patrick Canterino <patrick@patshaping.de>
+# Last modified: 2004-12-29
 #
 
 use strict;
@@ -23,7 +23,7 @@ use Command;
 use Output;
 use Tool;
 
-$VERSION = '2.0';
+$VERSION = '2.2a';
 
 # Path to configuration file
 # Change if necessary!
@@ -35,6 +35,14 @@ use constant CONFIGFILE => 'devedit.dat';
 my $config = read_config(CONFIGFILE);
 error_template($config->{'templates'}->{'error'}); # Yes, I'm lazy...
 
+# Check if the root directory exists
+
+abort($config->{'errors'}->{'no_root_dir'}) unless(-d $config->{'fileroot'});
+
+# Check if we are able to access the root directory
+
+abort($config->{'errors'}->{'no_root_access'}) unless(-r $config->{'fileroot'} && -x $config->{'fileroot'});
+
 # Read the most important form data
 
 my $cgi = new CGI;
@@ -45,7 +53,6 @@ my $curdir  = $cgi->param('curdir')  || '';
 my $newfile = $cgi->param('newfile') || '';
 
 # Create physical and virtual path for the new file
-# This section has to be optimized - ugh!
 
 my $new_physical = '';
 my $new_virtual  = '';
@@ -64,14 +71,22 @@ if($newfile ne '' && $newfile !~ /^\s+$/)
 
  unless(-d clean_path($config->{'fileroot'}."/".$dir))
  {
-  abort($config->{'errors'}->{'dir_not_exist'});
+  abort($config->{'errors'}->{'dir_not_exist'},"/");
  }
 
  # ... and check if the path is above the root directory
 
  unless(($new_physical,$new_virtual) = check_path($config->{'fileroot'},$dir))
  {
-  abort($config->{'errors'}->{'create_ar'});
+  abort($config->{'errors'}->{'create_ar'},"/");
+ }
+
+ # Check if we have enough permissions to create a file
+ # in this directory
+
+ unless(-r $new_physical && -w $new_physical && -x $new_physical)
+ {
+  abort($config->{'errors'}->{'dir_no_create'},"/",{DIR => $new_virtual});
  }
 
  # Create the physical and the virtual path
@@ -80,7 +95,7 @@ if($newfile ne '' && $newfile !~ /^\s+$/)
  $new_virtual .= $file;
 }
 
-# This check has to be performed first, or abs_path() will be confused
+# This check has to be performed first or abs_path() will be confused
 
 if(-e clean_path($config->{'fileroot'}."/".$file))
 {
@@ -92,7 +107,7 @@ if(-e clean_path($config->{'fileroot'}."/".$file))
                                   lockfile => $config->{'lock_file'},
                                   timeout  => $config->{'lock_timeout'});
 
-  $uselist->lock or abort($config->{'errors'}->{'lock_failed'},{USELIST => $config->{'uselist_file'}, LOCK_FILE => $config->{'lock_file'}});
+  $uselist->lock or abort($config->{'errors'}->{'lock_failed'},undef,{USELIST => $uselist->{'listfile'}, LOCK_FILE => $uselist->{'lockfile'}});
   $uselist->load;
 
   # Create a hash with data submitted by user
@@ -114,12 +129,12 @@ if(-e clean_path($config->{'fileroot'}."/".$file))
  }
  else
  {
-  abort($config->{'errors'}->{'above_root'});
+  abort($config->{'errors'}->{'above_root'},"/");
  }
 }
 else
 {
- abort($config->{'errors'}->{'not_exist'});
+ abort($config->{'errors'}->{'not_exist'},"/");
 }
 
 #