- Check if the user really wants to upload a file to a directory

[devedit.git] / modules / Command.pm

diff --git a/modules/Command.pm b/modules/Command.pm
index 117d39cafd69d47506aa9399d7e1c1e8243c81ce..84a03783b6000c6863fece596a0618ec3c392076 100644 (file)
--- a/modules/Command.pm
+++ b/modules/Command.pm
@@ -6,7 +6,7 @@ package Command;
 # Execute Dev-Editor's commands
 #
 # Author:        Patrick Canterino <patshaping@gmx.net>
 # Execute Dev-Editor's commands
 #
 # Author:        Patrick Canterino <patshaping@gmx.net>

-# Last modified: 2004-10-31
+# Last modified: 2004-11-24

 #
 
 use strict;
 #
 
 use strict;


@@ -89,6 +89,7 @@ sub exec_show($$)
  my ($data,$config) = @_;
  my $physical       = $data->{'physical'};
  my $virtual        = $data->{'virtual'};
  my ($data,$config) = @_;
  my $physical       = $data->{'physical'};
  my $virtual        = $data->{'virtual'};

+ my $upper_path     = upper_path($virtual);

  my $uselist        = $data->{'uselist'};
 
  my $tpl = new Template;
  my $uselist        = $data->{'uselist'};
 
  my $tpl = new Template;


@@ -97,8 +98,10 @@ sub exec_show($$)
  {
   # Create directory listing
 
  {
   # Create directory listing
 

+  return error($config->{'errors'}->{'no_dir_access'},$upper_path) unless(-r $physical && -x $physical);
+

   my $direntries = dir_read($physical);
   my $direntries = dir_read($physical);

-  return error($config->{'dir_read_failed'},upper_path($virtual),{DIR => '$virtual'}) unless($direntries);
+  return error($config->{'dir_read_fail'},$upper_path,{DIR => $virtual}) unless($direntries);

 
   my $files = $direntries->{'files'};
   my $dirs  = $direntries->{'dirs'};
 
   my $files = $direntries->{'files'};
   my $dirs  = $direntries->{'dirs'};


@@ -115,8 +118,8 @@ sub exec_show($$)
    my $udtpl = new Template;
    $udtpl->read_file($config->{'templates'}->{'dirlist_up'});
 
    my $udtpl = new Template;
    $udtpl->read_file($config->{'templates'}->{'dirlist_up'});
 

-   $udtpl->fillin("UPPER_DIR",encode_entities(upper_path($virtual)));
-   $udtpl->fillin("DATE",strftime($config->{'timeformat'},localtime($stat[9])));
+   $udtpl->fillin("UPPER_DIR",encode_entities($upper_path));
+   $udtpl->fillin("DATE",encode_entities(strftime($config->{'timeformat'},localtime($stat[9]))));

 
    $dirlist .= $udtpl->get_template;
   }
 
    $dirlist .= $udtpl->get_template;
   }


@@ -125,18 +128,21 @@ sub exec_show($$)
 
   foreach my $dir(@$dirs)
   {
 
   foreach my $dir(@$dirs)
   {

-   my @stat      = stat($physical."/".$dir);
+   my $phys_path = $physical."/".$dir;

    my $virt_path = encode_entities($virtual.$dir."/");
 
    my $virt_path = encode_entities($virtual.$dir."/");
 

+   my @stat      = stat($phys_path);
+

    my $dtpl = new Template;
    $dtpl->read_file($config->{'templates'}->{'dirlist_dir'});
 
    $dtpl->fillin("DIR",$virt_path);
    $dtpl->fillin("DIR_NAME",$dir);
    my $dtpl = new Template;
    $dtpl->read_file($config->{'templates'}->{'dirlist_dir'});
 
    $dtpl->fillin("DIR",$virt_path);
    $dtpl->fillin("DIR_NAME",$dir);

-   $dtpl->fillin("DATE",strftime($config->{'timeformat'},localtime($stat[9])));
+   $dtpl->fillin("DATE",encode_entities(strftime($config->{'timeformat'},localtime($stat[9]))));

    $dtpl->fillin("URL",equal_url($config->{'httproot'},$virt_path));
 
    $dtpl->fillin("URL",equal_url($config->{'httproot'},$virt_path));
 

-   $dtpl->parse_if_block("users",$users && -o $physical."/".$dir);
+   $dtpl->parse_if_block("readable",-r $phys_path && -x $phys_path);
+   $dtpl->parse_if_block("users",$users && -o $phys_path);

 
    $dirlist .= $dtpl->get_template;
   }
 
    $dirlist .= $dtpl->get_template;
   }


@@ -157,7 +163,7 @@ sub exec_show($$)
    $ftpl->fillin("FILE",$virt_path);
    $ftpl->fillin("FILE_NAME",$file);
    $ftpl->fillin("SIZE",$stat[7]);
    $ftpl->fillin("FILE",$virt_path);
    $ftpl->fillin("FILE_NAME",$file);
    $ftpl->fillin("SIZE",$stat[7]);

-   $ftpl->fillin("DATE",strftime($config->{'timeformat'},localtime($stat[9])));
+   $ftpl->fillin("DATE",encode_entities(strftime($config->{'timeformat'},localtime($stat[9]))));

    $ftpl->fillin("URL",equal_url($config->{'httproot'},$virt_path));
 
    $ftpl->parse_if_block("not_readable",not -r $phys_path);
    $ftpl->fillin("URL",equal_url($config->{'httproot'},$virt_path));
 
    $ftpl->parse_if_block("not_readable",not -r $phys_path);


@@ -189,7 +195,7 @@ sub exec_show($$)
  {
   # View a file
 
  {
   # View a file
 

-  return error($config->{'errors'}->{'noview'},upper_path($virtual)) unless(-r $physical);
+  return error($config->{'errors'}->{'noview'},$upper_path) unless(-r $physical);

 
   # Check on binary files
   # We have to do it in this way, or empty files
 
   # Check on binary files
   # We have to do it in this way, or empty files


@@ -199,17 +205,17 @@ sub exec_show($$)
   {
    # Binary file
 
   {
    # Binary file
 

-   return error($config->{'errors'}->{'binary'},upper_path($virtual));
+   return error($config->{'errors'}->{'binary'},$upper_path);

   }
   else
   {
    # Text file
 
   }
   else
   {
    # Text file
 

-   my $size = (stat($physical))[7];
+   my $size = -s $physical;

 
    if($config->{'max_file_size'} && $size > $config->{'max_file_size'})
    {
 
    if($config->{'max_file_size'} && $size > $config->{'max_file_size'})
    {

-    return error($config->{'errors'}->{'file_too_large'},upper_path($virtual),{SIZE => $config->{'max_file_size'}})
+    return error($config->{'errors'}->{'file_too_large'},$upper_path,{SIZE => $config->{'max_file_size'}})

    }
    else
    {
    }
    else
    {


@@ -219,7 +225,7 @@ sub exec_show($$)
     $tpl->read_file($config->{'templates'}->{'viewfile'});
 
     $tpl->fillin("FILE",$virtual);
     $tpl->read_file($config->{'templates'}->{'viewfile'});
 
     $tpl->fillin("FILE",$virtual);

-    $tpl->fillin("DIR",upper_path($virtual));
+    $tpl->fillin("DIR",$upper_path);

     $tpl->fillin("URL",equal_url($config->{'httproot'},$virtual));
     $tpl->fillin("SCRIPT",$script);
 
     $tpl->fillin("URL",equal_url($config->{'httproot'},$virtual));
     $tpl->fillin("SCRIPT",$script);
 


@@ -250,11 +256,12 @@ sub exec_beginedit($$)
  my ($data,$config) = @_;
  my $physical       = $data->{'physical'};
  my $virtual        = $data->{'virtual'};
  my ($data,$config) = @_;
  my $physical       = $data->{'physical'};
  my $virtual        = $data->{'virtual'};

+ my $dir            = upper_path($virtual);

  my $uselist        = $data->{'uselist'};
 
  my $uselist        = $data->{'uselist'};
 

- return error($config->{'errors'}->{'editdir'},upper_path($virtual))                   if(-d $physical);
- return error($config->{'errors'}->{'in_use'},upper_path($virtual),{FILE => $virtual}) if($uselist->in_use($virtual));
- return error($config->{'errors'}->{'noedit'},upper_path($virtual))                    unless(-r $physical && -w $physical);
+ return error($config->{'errors'}->{'editdir'},$dir)                    if(-d $physical);
+ return error($config->{'errors'}->{'in_use'}, $dir,{FILE => $virtual}) if($uselist->in_use($virtual));
+ return error($config->{'errors'}->{'noedit'}, $dir)                    unless(-r $physical && -w $physical);

 
  # Check on binary files
 
 
  # Check on binary files
 


@@ -262,13 +269,13 @@ sub exec_beginedit($$)
  {
   # Binary file
 
  {
   # Binary file
 

-  return error($config->{'errors'}->{'binary'},upper_path($virtual));
+  return error($config->{'errors'}->{'binary'},$dir);

  }
  else
  {
  }
  else
  {

-  if($config->{'max_file_size'} && (stat($physical))[7] > $config->{'max_file_size'})
+  if($config->{'max_file_size'} && (-s $physical) > $config->{'max_file_size'})

   {
   {

-   return error($config->{'errors'}->{'file_too_large'},upper_path($virtual),{SIZE => $config->{'max_file_size'}})
+   return error($config->{'errors'}->{'file_too_large'},$dir,{SIZE => $config->{'max_file_size'}})

   }
   else
   {
   }
   else
   {


@@ -284,7 +291,7 @@ sub exec_beginedit($$)
    $tpl->read_file($config->{'templates'}->{'editfile'});
 
    $tpl->fillin("FILE",$virtual);
    $tpl->read_file($config->{'templates'}->{'editfile'});
 
    $tpl->fillin("FILE",$virtual);

-   $tpl->fillin("DIR",upper_path($virtual));
+   $tpl->fillin("DIR",$dir);

    $tpl->fillin("URL",equal_url($config->{'httproot'},$virtual));
    $tpl->fillin("SCRIPT",$script);
    $tpl->fillin("CONTENT",encode_entities($$content));
    $tpl->fillin("URL",equal_url($config->{'httproot'},$virtual));
    $tpl->fillin("SCRIPT",$script);
    $tpl->fillin("CONTENT",encode_entities($$content));


@@ -329,6 +336,7 @@ sub exec_endedit($$)
  my ($data,$config) = @_;
  my $physical       = $data->{'physical'};
  my $virtual        = $data->{'virtual'};
  my ($data,$config) = @_;
  my $physical       = $data->{'physical'};
  my $virtual        = $data->{'virtual'};

+ my $dir            = upper_path($virtual);

  my $content        = $data->{'cgi'}->param('filecontent');
  my $uselist        = $data->{'uselist'};
 
  my $content        = $data->{'cgi'}->param('filecontent');
  my $uselist        = $data->{'uselist'};
 


@@ -360,22 +368,22 @@ sub exec_endedit($$)
 
   # Check if someone else is editing the new file
 
 
   # Check if someone else is editing the new file
 

-  return error($config->{'errors'}->{'in_use'},upper_path($virtual),{FILE => $virtual}) if($uselist->in_use($virtual));
+  return error($config->{'errors'}->{'in_use'},$dir,{FILE => $virtual}) if($uselist->in_use($virtual));

  }
 
  }
 

- return error($config->{'errors'}->{'text_to_binary'},upper_path($virtual)) unless(-T $physical);
- return error($config->{'errors'}->{'editdir'},upper_path($virtual))        if(-d $physical);
- return error($config->{'errors'}->{'noedit'}, upper_path($virtual))        if(-e $physical && !(-r $physical && -w $physical));
+ return error($config->{'errors'}->{'text_to_binary'},$dir) unless(-T $physical);
+ return error($config->{'errors'}->{'editdir'},$dir)        if(-d $physical);
+ return error($config->{'errors'}->{'noedit'}, $dir)        if(-e $physical && !(-r $physical && -w $physical));

 
  if(file_save($physical,\$content))
  {
   # Saving of the file was successful - so unlock it!
 
 
  if(file_save($physical,\$content))
  {
   # Saving of the file was successful - so unlock it!
 

-  return devedit_reload({command => 'show', file => upper_path($virtual)});
+  return devedit_reload({command => 'show', file => $dir});

  }
  else
  {
  }
  else
  {

-  return error($config->{'errors'}->{'edit_failed'},upper_path($virtual),{FILE => $virtual});
+  return error($config->{'errors'}->{'edit_failed'},$dir,{FILE => $virtual});

  }
 }
 
  }
 }
 


@@ -473,6 +481,8 @@ sub exec_upload($$)
  my $virtual        = $data->{'virtual'};
  my $cgi            = $data->{'cgi'};
 
  my $virtual        = $data->{'virtual'};
  my $cgi            = $data->{'cgi'};
 

+ return error($config->{'errors'}->{'no_directory'},upper_path($virtual),{FILE => $virtual}) unless(-d $physical);
+

  if(my $uploaded_file = $cgi->param('uploaded_file'))
  {
   # Process file upload
  if(my $uploaded_file = $cgi->param('uploaded_file'))
  {
   # Process file upload


@@ -759,12 +769,18 @@ sub exec_chprop($$)
 
  if($users)
  {
 
  if($users)
  {

+  # System supports user and groups
+

   if(-o $physical)
   {
   if(-o $physical)
   {

+   # We own this file
+

    if($mode || $group)
    {
     if($mode)
     {
    if($mode || $group)
    {
     if($mode)
     {

+     # Change the mode
+

      my $oct_mode = $mode;
      $oct_mode    = "0".$oct_mode if(length($oct_mode) == 3);
      $oct_mode    = oct($oct_mode);
      my $oct_mode = $mode;
      $oct_mode    = "0".$oct_mode if(length($oct_mode) == 3);
      $oct_mode    = oct($oct_mode);


@@ -774,7 +790,9 @@ sub exec_chprop($$)
 
     if($group)
     {
 
     if($group)
     {

-     return error($config->{'errors'}->{'invalid_group'},$dir,{GROUP => $group}) unless($group =~ /^[a-z0-9_]+[a-z0-9_-]*$/i);
+     # Change the group using the `chgrp` system command
+
+     return error($config->{'errors'}->{'invalid_group'},$dir,{GROUP => encode_entities($group)}) unless($group =~ /^[a-z0-9_]+[a-z0-9_-]*$/i);

      system("chgrp",$group,$physical);
     }
 
      system("chgrp",$group,$physical);
     }
 


@@ -782,20 +800,34 @@ sub exec_chprop($$)
    }
    else
    {
    }
    else
    {

+    # Display the form
+

     my @stat     = stat($physical);
 
     my $mode     = $stat[2];
     my $mode_oct = substr(sprintf("%04o",$mode),-4);
     my $gid      = $stat[5];
     my @stat     = stat($physical);
 
     my $mode     = $stat[2];
     my $mode_oct = substr(sprintf("%04o",$mode),-4);
     my $gid      = $stat[5];

-    my $group    = getgrgid($gid);

 
     my $tpl = new Template;
     $tpl->read_file($config->{'templates'}->{'chprop'});
 
 
     my $tpl = new Template;
     $tpl->read_file($config->{'templates'}->{'chprop'});
 

+    # Insert file properties into the template
+

     $tpl->fillin("MODE_OCTAL",$mode_oct);
     $tpl->fillin("MODE_STRING",mode_string($mode));
     $tpl->fillin("GID",$gid);
     $tpl->fillin("MODE_OCTAL",$mode_oct);
     $tpl->fillin("MODE_STRING",mode_string($mode));
     $tpl->fillin("GID",$gid);

-    $tpl->fillin("GROUP",$group);
+
+    if(my $group = getgrgid($gid))
+    {
+     $tpl->fillin("GROUP",encode_entities($group));
+     $tpl->parse_if_block("group_detected",1);
+    }
+    else
+    {
+     $tpl->parse_if_block("group_detected",0);
+    }
+
+    # Insert other information

 
     $tpl->fillin("FILE",$virtual);
     $tpl->fillin("DIR",$dir);
 
     $tpl->fillin("FILE",$virtual);
     $tpl->fillin("DIR",$dir);


@@ -883,21 +915,21 @@ sub exec_about($$)
 
  # Some path information
 
 
  # Some path information
 

- $tpl->fillin("SCRIPT_PHYS",$ENV{'SCRIPT_FILENAME'});
- $tpl->fillin("CONFIG_PATH",$data->{'configfile'});
- $tpl->fillin("FILE_ROOT",$config->{'fileroot'});
- $tpl->fillin("HTTP_ROOT",$config->{'httproot'});
+ $tpl->fillin("SCRIPT_PHYS",encode_entities($ENV{'SCRIPT_FILENAME'}));
+ $tpl->fillin("CONFIG_PATH",encode_entities($data->{'configfile'}));
+ $tpl->fillin("FILE_ROOT",  encode_entities($config->{'fileroot'}));
+ $tpl->fillin("HTTP_ROOT",  encode_entities($config->{'httproot'}));

 
  # Perl
 
 
  # Perl
 

- $tpl->fillin("PERL_PROG",$^X);
+ $tpl->fillin("PERL_PROG",encode_entities($^X));

  $tpl->fillin("PERL_VER",sprintf("%vd",$^V));
 
  # Information about the server
 
  $tpl->fillin("PERL_VER",sprintf("%vd",$^V));
 
  # Information about the server
 

- $tpl->fillin("HTTPD",$ENV{'SERVER_SOFTWARE'});
+ $tpl->fillin("HTTPD",encode_entities($ENV{'SERVER_SOFTWARE'}));

  $tpl->fillin("OS",$^O);
  $tpl->fillin("OS",$^O);

- $tpl->fillin("TIME",strftime($config->{'timeformat'},localtime));
+ $tpl->fillin("TIME",encode_entities(strftime($config->{'timeformat'},localtime)));

 
  # Process information
 
 
  # Process information
 


@@ -922,8 +954,25 @@ sub exec_about($$)
 
   # Names of user and group
 
 
   # Names of user and group
 

-  $tpl->fillin("USER",getpwuid($uid));
-  $tpl->fillin("GROUP",getgrgid($gid));
+  if(my $user = getpwuid($uid))
+  {
+   $tpl->fillin("USER",encode_entities($user));
+   $tpl->parse_if_block("user_detected",1);
+  }
+  else
+  {
+   $tpl->parse_if_block("user_detected",0);
+  }
+
+  if(my $group = getgrgid($gid))
+  {
+   $tpl->fillin("GROUP",encode_entities($group));
+   $tpl->parse_if_block("group_detected",1);
+  }
+  else
+  {
+   $tpl->parse_if_block("group_detected",0);
+  }

 
   # Process umask
 
 
   # Process umask