Removed the race condition in file_create() which could set a file to 0 if it

[devedit.git] / devedit.pl

diff --git a/devedit.pl b/devedit.pl
index 2c46f85f1884ee55e4f3f6541fae3ab7bb4534b5..aa4df1690266111272970de2d6b6faaabf045fbb 100644 (file)
--- a/devedit.pl
+++ b/devedit.pl
@@ -1,39 +1,39 @@
 #!C:/Programme/Perl/bin/perl.exe -w
 
 #
-# Dev-Editor 1.1
+# Dev-Editor 2.0 (CVS)
 #
 # Dev-Editor's main program
 #
 # Author:        Patrick Canterino <patshaping@gmx.net>
-# Last modified: 2003-12-02
+# Last modified: 2004-07-04
 #
 
 use strict;
 use CGI::Carp qw(fatalsToBrowser);
 
-use vars qw(%config);
-
+use vars qw($VERSION);
 use lib 'modules';
 
 use CGI;
-use Command;
+use Config::DevEdit;
 use File::UseList;
+
+use Command;
 use Output;
 use Tool;
 
-### Settings ###
+$VERSION = '2.0 (CVS)';
+
+# Path to configuration file
+# Change if necessary!
+
+use constant CONFIGFILE => 'devedit.dat';
 
-%config = (
-           fileroot     => 'D:/Server/WWW/dokumente/devedit-test',
-           httproot     => '/devedit-test/',
-           timeformat   => '%d.%m.%Y %H:%M',
-           uselist_file => 'uselist',
-           lock_file    => 'uselist.lock',
-           lock_timeout => '10'
-          );
+# Read the configuration file
 
-### End Settings ###
+my $config = read_config(CONFIGFILE);
+error_template($config->{'templates'}->{'error'}); # Yes, I'm lazy...
 
 # Read the most important form data
 
@@ -62,16 +62,16 @@ if($newfile ne '')
 
  # ... check if the directory exists ...
 
- unless(-d clean_path($config{'fileroot'}."/".$dir))
+ unless(-d clean_path($config->{'fileroot'}."/".$dir))
  {
-  abort("The directory where you want to create this file or directory doesn't exist.");
+  abort($config->{'errors'}->{'dir_not_exist'});
  }
 
  # ... and check if the path is above the root directory
 
- unless(($new_physical,$new_virtual) = check_path($config{'fileroot'},$dir))
+ unless(($new_physical,$new_virtual) = check_path($config->{'fileroot'},$dir))
  {
-  abort("You aren't allowed to create files and directories above the virtual root directory.");
+  abort($config->{'errors'}->{'create_ar'});
  }
 
  # Create the physical and the virtual path
@@ -82,42 +82,44 @@ if($newfile ne '')
 
 # This check has to be performed first, or abs_path() will be confused
 
-if(-e clean_path($config{'fileroot'}."/".$file))
+if(-e clean_path($config->{'fileroot'}."/".$file))
 {
- if(my ($physical,$virtual) = check_path($config{'fileroot'},$file))
+ if(my ($physical,$virtual) = check_path($config->{'fileroot'},$file))
  {
   # Create a File::UseList object and load the list
 
-  my $uselist = new File::UseList(listfile => $config{'uselist_file'},
-                                  lockfile => $config{'lock_file'},
-                                  timeout  => $config{'lock_timeout'});
+  my $uselist = new File::UseList(listfile => $config->{'uselist_file'},
+                                  lockfile => $config->{'lock_file'},
+                                  timeout  => $config->{'lock_timeout'});
 
-  $uselist->lock or abort("Locking of $config{'uselist_file'} failed. Try it again in a moment. If the problem persists, ask someone to recreate the lock file ($config{'lock_file'}).");
+  $uselist->lock or abort($config->{'errors'}->{'lock_failed'},{USELIST => $config->{'uselist_file'}, LOCK_FILE => $config->{'lock_file'}});
   $uselist->load;
 
   # Create a hash with data submitted by user
-  # (the CGI and the File::UseList object will also be included)
+  # (some other necessary information will also be included)
 
   my %data = (physical     => $physical,
               virtual      => $virtual,
               new_physical => $new_physical,
               new_virtual  => $new_virtual,
               uselist      => $uselist,
-              cgi          => $cgi);
+              cgi          => $cgi,
+              version      => $VERSION,
+              configfile   => CONFIGFILE);
 
-  my $output = exec_command($command,\%data,\%config); # Execute the command...
+  my $output = exec_command($command,\%data,$config); # Execute the command...
 
   $uselist->unlock; # ... unlock the list with files in use...
-  print $$output;   # ... and print the output of the command
+  print $$output;   # ... and show the output of the command
  }
  else
  {
-  abort("Accessing files and directories above the virtual root directory is forbidden.");
+  abort($config->{'errors'}->{'above_root'});
  }
 }
 else
 {
- abort("File/directory does not exist.");
+ abort($config->{'errors'}->{'not_exist'});
 }
 
 #