From 08ac1ab0d0b904bb65c6333264201ab07b195dbf Mon Sep 17 00:00:00 2001 From: Patrick Canterino Date: Sat, 30 Mar 2024 13:51:40 +0100 Subject: [PATCH 1/1] Check return value of `rename()` after encryption --- lib/functions.php | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/functions.php b/lib/functions.php index c42293b..805b958 100644 --- a/lib/functions.php +++ b/lib/functions.php @@ -460,8 +460,9 @@ function jirafeau_upload($file, $one_time_download, $key, $time, $ip, $crypt, $l if ($crypt == true && extension_loaded('sodium') == true) { $crypt_key = jirafeau_encrypt_file($file['tmp_name'], $file['tmp_name'].'crypt'); if (strlen($crypt_key) > 0) { - $crypted = true; - rename($file['tmp_name'].'crypt', $file['tmp_name']); + if (rename($file['tmp_name'].'crypt', $file['tmp_name']) === true) { + $crypted = true; + } } } @@ -1145,11 +1146,11 @@ function jirafeau_async_end($ref, $code, $crypt, $link_name_length, $file_hash_m $crypted = false; $crypt_key = ''; if ($crypt == true && extension_loaded('sodium') == true) { - //$crypt_key = jirafeau_encrypt_file($p, $p); $crypt_key = jirafeau_encrypt_file($p, $p.'.crypt'); if (strlen($crypt_key) > 0) { - $crypted = true; - rename($p.'.crypt', $p); + if (rename($p.'.crypt', $p) === true) { + $crypted = true; + } } } -- 2.34.1