admin.php: fix authentication bypass vulnerability

[jirafeau_mojo42.git] / admin.php

diff --git a/admin.php b/admin.php
index cad427cc35c9d7be4f3651f46fd11174be443147..a0ae04b6d3bca449b9a5d11f62571ea9def1da8f 100644 (file)
--- a/admin.php
+++ b/admin.php
@@ -53,7 +53,7 @@ if (isset ($_POST['action']) && (strcmp ($_POST['action'], 'logout') == 0))
 /* Check classic admin password authentification. */
 if (isset ($_POST['admin_password']) && empty($cfg['admin_http_auth_user']))
 {
 /* Check classic admin password authentification. */
 if (isset ($_POST['admin_password']) && empty($cfg['admin_http_auth_user']))
 {

-    if (strcmp ($cfg['admin_password'], $_POST['admin_password']) == 0)
+    if ($cfg['admin_password'] === $_POST['admin_password'])

         $_SESSION['admin_auth'] = true;
     else
     {
         $_SESSION['admin_auth'] = true;
     else
     {


@@ -128,8 +128,9 @@ if (!(isset ($_POST['action']) && strcmp ($_POST['action'], 'download') == 0))
 {
         require (JIRAFEAU_ROOT . 'lib/template/header.php');
         ?><h2><?php echo t('Admin interface'); ?></h2><?php
 {
         require (JIRAFEAU_ROOT . 'lib/template/header.php');
         ?><h2><?php echo t('Admin interface'); ?></h2><?php

+        ?><h2>(version <?php echo JIRAFEAU_VERSION ?>)</h2><?php

 
 

-        ?><div id = "install">
+        ?><div id = "admin">

         <fieldset><legend><?php echo t('Actions');?></legend>
         <table>
         <form action = "<?php echo basename(__FILE__); ?>" method = "post">
         <fieldset><legend><?php echo t('Actions');?></legend>
         <table>
         <form action = "<?php echo basename(__FILE__); ?>" method = "post">


@@ -148,7 +149,7 @@ if (!(isset ($_POST['action']) && strcmp ($_POST['action'], 'download') == 0))
         <tr>
             <input type = "hidden" name = "action" value = "clean_async"/>
             <td class = "info">
         <tr>
             <input type = "hidden" name = "action" value = "clean_async"/>
             <td class = "info">

-                <?php echo t('Clean old unfinished transferts'); ?>
+                <?php echo t('Clean old unfinished transfers'); ?>

             </td>
             <td></td>
             <td>
             </td>
             <td></td>
             <td>


@@ -212,8 +213,8 @@ if (!(isset ($_POST['action']) && strcmp ($_POST['action'], 'download') == 0))
         </form>
         </table>
         <form action = "<?php echo basename(__FILE__); ?>" method = "post">
         </form>
         </table>
         <form action = "<?php echo basename(__FILE__); ?>" method = "post">

-        <input type = "hidden" name = "action" value = "logout"/>
-        <input type = "submit" value = "<?php echo t('Logout'); ?>" />
+            <input type = "hidden" name = "action" value = "logout" />
+            <input type = "submit" value = "<?php echo t('Logout'); ?>" />

         </form>
         </fieldset></div><?php
 }
         </form>
         </fieldset></div><?php
 }