From: Jerome Jutteau <jerome@jutteau.fr>
Date: Tue, 18 Sep 2018 19:59:31 +0000 (+0200)
Subject: [BUGFIX] Fix crash when admin downloads
X-Git-Tag: 4.0.0~17
X-Git-Url: https://git.p6c8.net/jirafeau_project.git/commitdiff_plain/caa3a139b7702a1e6e076d23126e83d8348aa647?ds=inline;hp=71944676be76169b3a6c18f9942aaaf346d23ef1

[BUGFIX] Fix crash when admin downloads

If the admin tries to download a big file, the file read can cause a
crash.

Fixes #174

Signed-off-by: Jerome Jutteau <jerome@jutteau.fr>
---

diff --git a/admin.php b/admin.php
index 3e8f517..4a3d25f 100644
--- a/admin.php
+++ b/admin.php
@@ -255,7 +255,12 @@ if (php_sapi_name() == "cli") {
           header('Content-Disposition: attachment; filename="' .
                   $l['file_name'] . '"');
           if (file_exists(VAR_FILES . $p . $l['md5'])) {
-              readfile(VAR_FILES . $p . $l['md5']);
+              $r = fopen(VAR_FILES . $p . $l['md5'], 'r');
+              while (!feof($r)) {
+                  print fread($r, 1024);
+                  ob_flush();
+              }
+              fclose($r);
           }
           exit;
       }