Optimized cleaning up old backups

[nextcloud-backup-restore.git] / NextcloudBackup.sh

diff --git a/NextcloudBackup.sh b/NextcloudBackup.sh
index a0299e66ad4b47c66207d33a6417b95120ec5148..4c735de490ef6a6c5cf13cc9b48bf0b8e176408f 100644 (file)
--- a/NextcloudBackup.sh
+++ b/NextcloudBackup.sh
@@ -3,7 +3,7 @@
 #
 # Bash script for creating backups of Nextcloud.
 #
 #
 # Bash script for creating backups of Nextcloud.
 #

-# Version 2.1.0
+# Version 2.1.1

 #
 # Usage:
 #      - With backup directory specified in the script:  ./NextcloudBackup.sh
 #
 # Usage:
 #      - With backup directory specified in the script:  ./NextcloudBackup.sh


@@ -24,6 +24,8 @@ backupMainDir=$1
 if [ -z "$backupMainDir" ]; then
        # TODO: The directory where you store the Nextcloud backups (when not specified by args)
     backupMainDir='/media/hdd/nextcloud_backup'
 if [ -z "$backupMainDir" ]; then
        # TODO: The directory where you store the Nextcloud backups (when not specified by args)
     backupMainDir='/media/hdd/nextcloud_backup'

+else
+       backupMainDir=$(echo $backupMainDir | sed 's:/*$::')

 fi
 
 currentDate=$(date +"%Y%m%d_%H%M%S")
 fi
 
 currentDate=$(date +"%Y%m%d_%H%M%S")


@@ -265,7 +267,7 @@ if [ ${maxNrOfBackups} != 0 ]
 then
        nrOfBackups=$(ls -l ${backupMainDir} | grep -c ^d)
 
 then
        nrOfBackups=$(ls -l ${backupMainDir} | grep -c ^d)
 

-       if [[ ${nrOfBackups} > ${maxNrOfBackups} ]]
+       if [ ${nrOfBackups} -gt ${maxNrOfBackups} ]

        then
                echo "Removing old backups..."
                ls -t ${backupMainDir} | tail -$(( nrOfBackups - maxNrOfBackups )) | while read -r dirToRemove; do
        then
                echo "Removing old backups..."
                ls -t ${backupMainDir} | tail -$(( nrOfBackups - maxNrOfBackups )) | while read -r dirToRemove; do