v2.3.0: Bugfix double slashes; exit on error; optimizations

[nextcloud-backup-restore.git] / NextcloudBackup.sh

diff --git a/NextcloudBackup.sh b/NextcloudBackup.sh
index 0b03af13afe5deaf85510261289b47392cf9ab9a..f719087bcf9fe0b0e4b5e9c0d9a374b98179a215 100644 (file)
--- a/NextcloudBackup.sh
+++ b/NextcloudBackup.sh
@@ -3,13 +3,20 @@
 #
 # Bash script for creating backups of Nextcloud.
 #
 #
 # Bash script for creating backups of Nextcloud.
 #

-# Version 2.1.0
+# Version 2.3.0
+#
+# Requirements:
+#      - pigz (https://zlib.net/pigz/) for using backup compression. If not available, you can use another compression algorithm (e.g. gzip)
+#
+# Supported database systems:
+#      - MySQL/MariaDB
+#      - PostgreSQL

 #
 # Usage:
 #      - With backup directory specified in the script:  ./NextcloudBackup.sh
 #      - With backup directory specified by parameter: ./NextcloudBackup.sh <BackupDirectory> (e.g. ./NextcloudBackup.sh /media/hdd/nextcloud_backup)
 #
 #
 # Usage:
 #      - With backup directory specified in the script:  ./NextcloudBackup.sh
 #      - With backup directory specified by parameter: ./NextcloudBackup.sh <BackupDirectory> (e.g. ./NextcloudBackup.sh /media/hdd/nextcloud_backup)
 #

-# The script is based on an installation of Nextcloud using nginx and MariaDB, see https://decatec.de/home-server/nextcloud-auf-ubuntu-server-18-04-lts-mit-nginx-mariadb-php-lets-encrypt-redis-und-fail2ban/
+# The script is based on an installation of Nextcloud using nginx and MariaDB, see https://decatec.de/home-server/nextcloud-auf-ubuntu-server-20-04-lts-mit-nginx-mariadb-php-lets-encrypt-redis-und-fail2ban/

 #
 
 #
 #
 
 #


@@ -18,25 +25,34 @@
 # All entries which need to be customized are tagged with "TODO".
 #
 
 # All entries which need to be customized are tagged with "TODO".
 #
 

+# Make sure the script exits when any command fails
+set -Eeuo pipefail
+

 # Variables
 backupMainDir=$1
 
 if [ -z "$backupMainDir" ]; then
        # TODO: The directory where you store the Nextcloud backups (when not specified by args)
 # Variables
 backupMainDir=$1
 
 if [ -z "$backupMainDir" ]; then
        # TODO: The directory where you store the Nextcloud backups (when not specified by args)

-    backupMainDir='/media/hdd/nextcloud_backup'
+       backupMainDir='/media/hdd/nextcloud_backup'
+else
+       backupMainDir=$(echo $backupMainDir | sed 's:/*$::')

 fi
 
 currentDate=$(date +"%Y%m%d_%H%M%S")
 
 # The actual directory of the current backup - this is a subdirectory of the main directory above with a timestamp
 fi
 
 currentDate=$(date +"%Y%m%d_%H%M%S")
 
 # The actual directory of the current backup - this is a subdirectory of the main directory above with a timestamp

-backupdir="${backupMainDir}/${currentDate}/"
+backupdir="${backupMainDir}/${currentDate}"

 
 

-# TODO: Use compression for Matrix Synapse installation/lib dir
+# TODO: Use compression for file/data dir

 # When this is the only script for backups, it's recommend to enable compression.
 # If the output of this script is used in another (compressing) backup (e.g. borg backup), 
 # you should probably disable compression here and only enable compression of your main backup script.
 useCompression=true
 
 # When this is the only script for backups, it's recommend to enable compression.
 # If the output of this script is used in another (compressing) backup (e.g. borg backup), 
 # you should probably disable compression here and only enable compression of your main backup script.
 useCompression=true
 

+# TOOD: The bare tar command for using compression.
+# Use 'tar -cpzf' if you want to use gzip compression.
+compressionCommand="tar -I pigz -cpf"
+

 # TODO: The directory of your Nextcloud installation (this is a directory under your web root)
 nextcloudFileDir='/var/www/nextcloud'
 
 # TODO: The directory of your Nextcloud installation (this is a directory under your web root)
 nextcloudFileDir='/var/www/nextcloud'
 


@@ -83,12 +99,15 @@ if [ "$useCompression" = true ] ; then
        fileNameBackupDataDir='nextcloud-datadir.tar.gz'
 fi
 
        fileNameBackupDataDir='nextcloud-datadir.tar.gz'
 fi
 

-# TODO: Uncomment if you use local external storage
-#fileNameBackupExternalDataDir='nextcloud-external-datadir.tar'
-#
-#if [ "$useCompression" = true ] ; then
-#      fileNameBackupExternalDataDir='nextcloud-external-datadir.tar.gz'
-#fi
+fileNameBackupExternalDataDir=''
+
+if [ ! -z "${nextcloudLocalExternalDataDir+x}" ] ; then
+       fileNameBackupExternalDataDir='nextcloud-external-datadir.tar'
+
+       if [ "$useCompression" = true ] ; then
+               fileNameBackupExternalDataDir='nextcloud-external-datadir.tar.gz'
+       fi
+fi

 
 fileNameBackupDb='nextcloud-db.sql'
 
 
 fileNameBackupDb='nextcloud-db.sql'
 


@@ -96,7 +115,7 @@ fileNameBackupDb='nextcloud-db.sql'
 errorecho() { cat <<< "$@" 1>&2; }
 
 function DisableMaintenanceMode() {
 errorecho() { cat <<< "$@" 1>&2; }
 
 function DisableMaintenanceMode() {

-       echo "Switching off maintenance mode..."
+       echo "$(date +"%H:%M:%S"): Switching off maintenance mode..."

        sudo -u "${webserverUser}" php ${nextcloudFileDir}/occ maintenance:mode --off
        echo "Done"
        echo
        sudo -u "${webserverUser}" php ${nextcloudFileDir}/occ maintenance:mode --off
        echo "Done"
        echo


@@ -152,7 +171,7 @@ fi
 #
 # Set maintenance mode
 #
 #
 # Set maintenance mode
 #

-echo "Set maintenance mode for Nextcloud..."
+echo "$(date +"%H:%M:%S"): Set maintenance mode for Nextcloud..."

 sudo -u "${webserverUser}" php ${nextcloudFileDir}/occ maintenance:mode --on
 echo "Done"
 echo
 sudo -u "${webserverUser}" php ${nextcloudFileDir}/occ maintenance:mode --on
 echo "Done"
 echo


@@ -160,7 +179,7 @@ echo
 #
 # Stop web server
 #
 #
 # Stop web server
 #

-echo "Stopping web server..."
+echo "$(date +"%H:%M:%S"): Stopping web server..."

 systemctl stop "${webserverServiceName}"
 echo "Done"
 echo
 systemctl stop "${webserverServiceName}"
 echo "Done"
 echo


@@ -168,10 +187,10 @@ echo
 #
 # Backup file directory
 #
 #
 # Backup file directory
 #

-echo "Creating backup of Nextcloud file directory..."
+echo "$(date +"%H:%M:%S"): Creating backup of Nextcloud file directory..."

 
 if [ "$useCompression" = true ] ; then
 
 if [ "$useCompression" = true ] ; then

-       tar -cpzf "${backupdir}/${fileNameBackupFileDir}" -C "${nextcloudFileDir}" .
+       `$compressionCommand "${backupdir}/${fileNameBackupFileDir}" -C "${nextcloudFileDir}" .`

 else
        tar -cpf "${backupdir}/${fileNameBackupFileDir}" -C "${nextcloudFileDir}" .
 fi
 else
        tar -cpf "${backupdir}/${fileNameBackupFileDir}" -C "${nextcloudFileDir}" .
 fi


@@ -182,19 +201,19 @@ echo
 #
 # Backup data directory
 #
 #
 # Backup data directory
 #

-echo "Creating backup of Nextcloud data directory..."
+echo "$(date +"%H:%M:%S"): Creating backup of Nextcloud data directory..."

 
 if [ "$ignoreUpdaterBackups" = true ] ; then
        echo "Ignoring updater backup directory"
 
        if [ "$useCompression" = true ] ; then
 
 if [ "$ignoreUpdaterBackups" = true ] ; then
        echo "Ignoring updater backup directory"
 
        if [ "$useCompression" = true ] ; then

-               tar -cpzf "${backupdir}/${fileNameBackupDataDir}"  --exclude="updater-*/backups/*" -C "${nextcloudDataDir}" .
+               `$compressionCommand "${backupdir}/${fileNameBackupDataDir}"  --exclude="updater-*/backups/*" -C "${nextcloudDataDir}" .`

        else
                tar -cpf "${backupdir}/${fileNameBackupDataDir}"  --exclude="updater-*/backups/*" -C "${nextcloudDataDir}" .
        fi
 else
        if [ "$useCompression" = true ] ; then
        else
                tar -cpf "${backupdir}/${fileNameBackupDataDir}"  --exclude="updater-*/backups/*" -C "${nextcloudDataDir}" .
        fi
 else
        if [ "$useCompression" = true ] ; then

-        tar -cpzf "${backupdir}/${fileNameBackupDataDir}"  -C "${nextcloudDataDir}" .
+               `$compressionCommand "${backupdir}/${fileNameBackupDataDir}"  -C "${nextcloudDataDir}" .`

        else
                tar -cpf "${backupdir}/${fileNameBackupDataDir}"  -C "${nextcloudDataDir}" .
        fi
        else
                tar -cpf "${backupdir}/${fileNameBackupDataDir}"  -C "${nextcloudDataDir}" .
        fi


@@ -203,23 +222,27 @@ fi
 echo "Done"
 echo
 
 echo "Done"
 echo
 

+#

 # Backup local external storage.
 # Backup local external storage.

-# Uncomment if you use local external storage
-#echo "Creating backup of Nextcloud local external storage directory..."
-#if [ "$useCompression" = true ] ; then
-#      tar -cpzf "${backupdir}/${fileNameBackupExternalDataDir}"  -C "${nextcloudLocalExternalDataDir}" .
-#else
-#      tar -cpf "${backupdir}/${fileNameBackupExternalDataDir}"  -C "${nextcloudLocalExternalDataDir}" .
-#fi
+#
+if [ ! -z "${nextcloudLocalExternalDataDir+x}" ] ; then
+       echo "$(date +"%H:%M:%S"): Creating backup of Nextcloud local external storage directory..."
+
+       if [ "$useCompression" = true ] ; then
+               `$compressionCommand "${backupdir}/${fileNameBackupExternalDataDir}"  -C "${nextcloudLocalExternalDataDir}" .`
+       else
+               tar -cpf "${backupdir}/${fileNameBackupExternalDataDir}"  -C "${nextcloudLocalExternalDataDir}" .
+       fi

 
 

-#echo "Done"
-#echo
+       echo "Done"
+       echo
+fi

 
 #
 # Backup DB
 #
 if [ "${databaseSystem,,}" = "mysql" ] || [ "${databaseSystem,,}" = "mariadb" ]; then
 
 #
 # Backup DB
 #
 if [ "${databaseSystem,,}" = "mysql" ] || [ "${databaseSystem,,}" = "mariadb" ]; then

-       echo "Backup Nextcloud database (MySQL/MariaDB)..."
+       echo "$(date +"%H:%M:%S"): Backup Nextcloud database (MySQL/MariaDB)..."

 
        if ! [ -x "$(command -v mysqldump)" ]; then
                errorecho "ERROR: MySQL/MariaDB not installed (command mysqldump not found)."
 
        if ! [ -x "$(command -v mysqldump)" ]; then
                errorecho "ERROR: MySQL/MariaDB not installed (command mysqldump not found)."


@@ -231,7 +254,7 @@ if [ "${databaseSystem,,}" = "mysql" ] || [ "${databaseSystem,,}" = "mariadb" ];
        echo "Done"
        echo
 elif [ "${databaseSystem,,}" = "postgresql" ] || [ "${databaseSystem,,}" = "pgsql" ]; then
        echo "Done"
        echo
 elif [ "${databaseSystem,,}" = "postgresql" ] || [ "${databaseSystem,,}" = "pgsql" ]; then

-       echo "Backup Nextcloud database (PostgreSQL)..."
+       echo "$(date +"%H:%M:%S"): Backup Nextcloud database (PostgreSQL)..."

 
        if ! [ -x "$(command -v pg_dump)" ]; then
                errorecho "ERROR: PostgreSQL not installed (command pg_dump not found)."
 
        if ! [ -x "$(command -v pg_dump)" ]; then
                errorecho "ERROR: PostgreSQL not installed (command pg_dump not found)."


@@ -247,7 +270,7 @@ fi
 #
 # Start web server
 #
 #
 # Start web server
 #

-echo "Starting web server..."
+echo "$(date +"%H:%M:%S"): Starting web server..."

 systemctl start "${webserverServiceName}"
 echo "Done"
 echo
 systemctl start "${webserverServiceName}"
 echo "Done"
 echo


@@ -264,9 +287,9 @@ if [ ${maxNrOfBackups} != 0 ]
 then
        nrOfBackups=$(ls -l ${backupMainDir} | grep -c ^d)
 
 then
        nrOfBackups=$(ls -l ${backupMainDir} | grep -c ^d)
 

-       if [[ ${nrOfBackups} > ${maxNrOfBackups} ]]
+       if [ ${nrOfBackups} -gt ${maxNrOfBackups} ]

        then
        then

-               echo "Removing old backups..."
+               echo "$(date +"%H:%M:%S"): Removing old backups..."

                ls -t ${backupMainDir} | tail -$(( nrOfBackups - maxNrOfBackups )) | while read -r dirToRemove; do
                        echo "${dirToRemove}"
                        rm -r "${backupMainDir}/${dirToRemove:?}"
                ls -t ${backupMainDir} | tail -$(( nrOfBackups - maxNrOfBackups )) | while read -r dirToRemove; do
                        echo "${dirToRemove}"
                        rm -r "${backupMainDir}/${dirToRemove:?}"


@@ -278,4 +301,4 @@ fi
 
 echo
 echo "DONE!"
 
 echo
 echo "DONE!"

-echo "Backup created: ${backupdir}"
+echo "$(date +"%H:%M:%S"): Backup created: ${backupdir}"