Merge pull request #4 from mmartinortiz/fix-deleting-old-backups

[nextcloud-backup-restore.git] / NextcloudBackup.sh

diff --git a/NextcloudBackup.sh b/NextcloudBackup.sh
index 469d9d19ed0cddfed69847115bff5e97efa4f455..dae6e7faf489533826c9573910186791254602d7 100644 (file)
--- a/NextcloudBackup.sh
+++ b/NextcloudBackup.sh
@@ -24,13 +24,15 @@ nextcloudFileDir="/var/www/nextcloud"
 # TODO: The directory of your Nextcloud data directory (outside the Nextcloud file directory)
 # If your data directory is located under Nextcloud's file directory (somewhere in the web root), the data directory should not be a separate part of the backup
 nextcloudDataDir="/var/nextcloud_data"
+# TODO: The service name of the web server. Used to start/stop web server (e.g. 'service <webserverServiceName> start')
+webserverServiceName="nginx"
 # TODO: Your Nextcloud database name
 nextcloudDatabase="nextcloud_db"
 # TODO: Your Nextcloud database user
 dbUser="nextcloud_db_user"
 # TODO: The password of the Nextcloud database user
 dbPassword="mYpAsSw0rd"
-# TODO: Your webserver user
+# TODO: Your web server user
 webserverUser="www-data"
 # TODO: The maximum number of backups to keep (when set to 0, all backups are kept)
 maxNrOfBackups=0
@@ -75,10 +77,10 @@ echo "Done"
 echo
 
 #
-# Stop webserver
+# Stop web server
 #
-echo "Stopping nginx..."
-service nginx stop
+echo "Stopping web server..."
+service "${webserverServiceName}" stop
 echo "Done"
 echo
 
@@ -104,10 +106,10 @@ echo "Done"
 echo
 
 #
-# Start webserver
+# Start web server
 #
-echo "Starting webserver..."
-service nginx start
+echo "Starting web server..."
+service "${webserverServiceName}" start
 echo "Done"
 echo
 
@@ -124,11 +126,11 @@ echo
 #
 # Delete old backups
 #
-if [ ${maxNrOfBackups} != 0 ]
+if (( ${maxNrOfBackups} != 0 ))
 then   
        nrOfBackups=$(ls -l ${backupMainDir} | grep -c ^d)
        
-       if [  ${maxNrOfBackups} > ${nrOfBackups}} ]
+       if (( ${nrOfBackups} > ${maxNrOfBackups} ))
        then
                echo "Removing old backups..."
                ls -t ${backupMainDir} | tail -$(( nrOfBackups - maxNrOfBackups )) | while read dirToRemove; do