From 818b32455bad7a84a693e342be35e2cb22de04ce Mon Sep 17 00:00:00 2001 From: Patrick Canterino Date: Wed, 12 Apr 2023 20:39:55 +0200 Subject: [PATCH 1/1] "publication_date" is now an annotated field "publication_date" is "published_at" if it is not null, else "created_at" It allows us to order the notes by this field --- notes/models.py | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/notes/models.py b/notes/models.py index c38e3d5..0056f0e 100644 --- a/notes/models.py +++ b/notes/models.py @@ -1,6 +1,6 @@ from django.db import models from django.db.models import Count -from django.db.models.functions import ExtractYear, ExtractMonth +from django.db.models.functions import ExtractYear, ExtractMonth, Coalesce from django.db.models.signals import pre_save from django.dispatch import receiver @@ -19,10 +19,10 @@ class NoteQuerySet(models.QuerySet): class NoteManager(models.Manager): def all_published(self): - return super().get_queryset().filter(status=1) + return super().get_queryset().filter(status=1).annotate(publication_date=Coalesce('published_at', 'created_at')).order_by('-publication_date') - def all_with_unpublished(self): - return super().all() + def all(self): + return super().all().annotate(publication_date=Coalesce('published_at', 'created_at')).order_by('-publication_date') def per_year(self, year): return self.all_published().filter(created_at__year=year) @@ -70,12 +70,6 @@ class Note(models.Model): def is_published(self): return self.status == 1 - def publication_date(self): - if self.published_at is None: - return self.created_at - else: - return self.published_at - @receiver(pre_save, sender=Note) def note_pre_save(sender, instance, **kwargs): if instance.pk is None: -- 2.34.1