Rotate only if mysqldump succeeded

[psmysqlbackup.git] / psmysqlbackup.ps1

diff --git a/psmysqlbackup.ps1 b/psmysqlbackup.ps1
index 97bcf859f3791b3bd8e3481a6a17b1a1e81fa886..d11f52e24ef8572493cc7785852bcbe8085c518f 100644 (file)
--- a/psmysqlbackup.ps1
+++ b/psmysqlbackup.ps1
@@ -1,21 +1,36 @@
-[String]$configMysqlHost = "localhost"
-[Int32]$configMysqlPort = 3306
-[String]$configMysqlUser = "backup"
-[String]$configMysqlPassword = "backup"
+# PSMySQLBackup
+# PowerShell script for backing up MySQL / MariaDB databases on Windows 
+#
+# Author: Patrick Canterino <patrick@patrick-canterino.de>
+# WWW: https://www.patrick-canterino.de/
+#      https://github.com/pcanterino/dsmonrot
+# License: 2-Clause BSD License
 
-[String]$configMysqlCli = "C:\Program Files\MariaDB 10.5\bin\mysql.exe"
-[String]$configMysqldumpCli = "C:\Program Files\MariaDB 10.5\bin\mysqldump.exe"
+# Config
 
-[String]$configBackupDir = "backup"
-[Int32]$configRotate = 7
+$configMysqlHost = "localhost"
+$configMysqlPort = 3306
+$configMysqlUser = "backup"
+$configMysqlPassword = "backup"
+
+$configMysqlCli = "C:\Program Files\MariaDB 10.5\bin\mysql.exe"
+$configMysqldumpCli = "C:\Program Files\MariaDB 10.5\bin\mysqldump.exe"
+
+$configBackupDir = "backup"
+$configRotate = 7
 
 $configDbBackup = @()
 $configDbExclusions = @("test")
 
-$defaultExclusions = @("information_schema", "performance_schema")
+# End of config
 
 function Get-Databases() {
     $databaseString = (& $configMysqlCli --host=$configMysqlHost --port=$configMysqlPort --user=$configMysqlUser --password=$configMysqlPassword --batch --skip-column-names -e "SHOW DATABASES;")
+    
+    if($LastExitCode -ne 0) {
+        throw "MySQL CLI exited with Exit code $LastExitCode"
+    }
+    
     $databases = $databaseString.split([Environment]::NewLine)
 
     return $databases
@@ -23,31 +38,44 @@ function Get-Databases() {
 
 function Create-Backup([String]$database, [String]$target) {
     & $configMysqldumpCli --host=$configMysqlHost --port=$configMysqlPort --user=$configMysqlUser --password=$configMysqlPassword --single-transaction --result-file=$target $database
+
+    if($LastExitCode -ne 0) {
+        throw "mysqldump exited with Exit code $LastExitCode"
+    }
 }
 
 function Rotate-Backups($backupDir) {
     if($configRotate -le 0) {
-               return
-       }
-       
-       $keepBackupsCount = $configRotate
-       
-       Get-ChildItem $backupDir -File | Where-Object {($_.Name -match "^backup-.+-\d{8,}-\d{6}\.sql$")} | Sort-Object -Descending |
-       Foreach-Object {
-               if($keepBackupsCount -ge 0) {
-                       $keepBackupsCount--
-               }
-               
-               if($keepBackupsCount -eq -1) {
-                       Write-Output "Deleting backup $($_.FullName)"
-                       Remove-Item -Force $_.FullName
-               }
-       }
+        return
+    }
+    
+    $keepBackupsCount = $configRotate
+
+    Get-ChildItem $backupDir -File | Where-Object {($_.Name -match "^backup-.+-\d{8,}-\d{6}\.sql$")} | Sort-Object -Descending |
+    Foreach-Object {
+        if($keepBackupsCount -ge 0) {
+            $keepBackupsCount--
+        }
+
+        if($keepBackupsCount -eq -1) {
+            Write-Output "Deleting backup $($_.FullName)"
+            Remove-Item -Force $_.FullName
+        }
+    }
 }
 
+$defaultExclusions = @("information_schema", "performance_schema")
+
 $currDaytime = Get-Date -format "yyyyMMdd-HHmmss"
 
-$databases = Get-Databases | Where-Object {!($_ -in $defaultExclusions -or $_ -in $configDbExclusions)}
+try {
+    $databases = Get-Databases | Where-Object {!($_ -in $defaultExclusions -or $_ -in $configDbExclusions)}
+}
+catch {
+    Write-Output "Failed to get list of databases"
+    Write-Output $_
+    exit 1
+}
 
 $databasesToBackup = @()
 
@@ -67,6 +95,13 @@ foreach($d in $databasesToBackup) {
 
     $databaseBackupFile = Join-Path -Path $databaseBackupDir -ChildPath "backup-$d-$currDaytime.sql"
     Write-Output "Backing up $d to $databaseBackupFile..."
-    Create-Backup $d $databaseBackupFile
-    Rotate-Backups $databaseBackupDir
+    
+    try {
+        Create-Backup $d $databaseBackupFile
+        Rotate-Backups $databaseBackupDir
+    }
+    catch {
+        Write-Output "Could not backup database $d to $databaseBackupFile"
+        Write-Output $_
+    }
 }
\ No newline at end of file