improved the behavior of get_all_threads and create_forum_xml_string

[selfforum.git] / selfforum-cgi / user / fo_voting.pl

diff --git a/selfforum-cgi/user/fo_voting.pl b/selfforum-cgi/user/fo_voting.pl
index 8ab2d0f71e261810af2f40691c94985507bcaa5f..6cd5e5ce815109de17bb4f87df9597fb2d5a9485 100644 (file)
--- a/selfforum-cgi/user/fo_voting.pl
+++ b/selfforum-cgi/user/fo_voting.pl
@@ -4,7 +4,7 @@
 #                                                                              #
 # File:        user/fo_voting.pl                                               #
 #                                                                              #
-# Authors:     André Malo <nd@o3media.de>, 2001-04-23                          #
+# Authors:     André Malo <nd@o3media.de>                                      #
 #                                                                              #
 # Description: vote a posting, return the posting view                         #
 #                                                                              #
@@ -16,7 +16,6 @@ use vars qw(
   $Shared
   $Script
   $Config
-  $VERSION
 );
 
 BEGIN {
@@ -45,11 +44,22 @@ use Conf::Admin;
 use Posting::Cache;
 use Template::Posting;
 
-use CGI qw(param header remote_addr request_method);
+use CGI qw(
+  param
+  header
+  remote_addr
+  request_method
+);
 
+################################################################################
+#
 # Version check
 #
-$VERSION = do { my @r =(q$Revision$ =~ /\d+/g); sprintf "%d."."%02d" x $#r, @r };
+# last modified:
+#    $Date$ (GMT)
+# by $Author$
+#
+sub VERSION {(q$Revision$ =~ /([\d.]+)\s*$/)[0] or '0.0'}
 
 my $conf = read_script_conf ($Config, $Shared, $Script);
 
@@ -70,8 +80,8 @@ my $voted;
 
 my ($tid, $mid) = map {$_ || 0} split /;/ => $fup, 2;
 
-$tid = ($tid=~/(\d+)/)[0] || 0;
-$mid = ($mid=~/(\d+)/)[0] || 0;
+$tid = (defined $tid and $tid=~/(\d+)/)? $1: 0;
+$mid = (defined $mid and $mid=~/(\d+)/)? $1: 0;
 
 if ($tid and $mid and $unid) {