/* Forbid specific file extensions from being uploaded.
* Leave empty to allow every extension.
* Extensions are matched case-insensitively and without the leading dot.
- * $cfg['disallowed_extensions'] = array('exe', 'bat', 'sh', 'php');
+ * Compound extensions such as 'tar.gz' are supported. Note that 'gz'
+ * also covers 'tar.gz', while 'tar.gz' leaves plain '.gz' files allowed.
+ * $cfg['disallowed_extensions'] = array('exe', 'bat', 'sh', 'php', 'tar.gz');
*/
$cfg['disallowed_extensions'] = array();
// just warns the user before they submit a doomed upload.
function control_selected_file_extension(disallowed_extensions, error_str)
{
- f_name = document.getElementById('file_select').files[0].name.replace(/[\s.]+$/, '');
- f_ext = f_name.includes('.') ? f_name.split('.').pop().toLowerCase() : '';
- if (disallowed_extensions.includes(f_ext))
+ f_name = document.getElementById('file_select').files[0].name.replace(/[\s.]+$/, '').toLowerCase();
+ // suffix match so that compound extensions such as 'tar.gz' work too
+ if (disallowed_extensions.some(function (ext) { return f_name.endsWith('.' + ext); }))
{
// control_selected_file_size runs first: keep its error, if any, and add ours
var error_pop = document.getElementById('error_pop');
}
// trailing dots and whitespace are dropped on storage or by the client OS
- $filename = rtrim($filename, " \t\n\r\0\x0B.");
- $extension = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
- $disallowed = array_map('strtolower', $cfg['disallowed_extensions']);
+ $filename = strtolower(rtrim($filename, " \t\n\r\0\x0B."));
- return !in_array($extension, $disallowed);
+ // suffix match so that compound extensions such as 'tar.gz' work too;
+ // 'gz' still covers 'archive.tar.gz'
+ foreach ($cfg['disallowed_extensions'] as $extension) {
+ $suffix = '.' . strtolower($extension);
+ if (substr($filename, -strlen($suffix)) === $suffix) {
+ return false;
+ }
+ }
+
+ return true;
}
/**