[FIX] Better error handling with md5_outside

Signed-off-by: Jerome Jutteau <jerome@jutteau.fr>

diff --git a/lib/functions.php b/lib/functions.php
index 4e227967475973466a0c186fcbf616aeeaecf559..5a5316c2e1ec11560e915710d43541843ad04090 100644 (file)
--- a/lib/functions.php
+++ b/lib/functions.php
@@ -343,22 +343,30 @@ function jirafeau_hash_file($method, $file_path)
  */
 function jirafeau_md5_outside($file_path)
 {
  */
 function jirafeau_md5_outside($file_path)
 {

-    $size = filesize($file_path);
-    if ($size === false) {
-        $size = 0;
-    }
+    $out = false;

     $handle = fopen($file_path, "r");
     if ($handle === false) {
         return false;
     }
     $handle = fopen($file_path, "r");
     if ($handle === false) {
         return false;
     }

+    $size = filesize($file_path);
+    if ($size === false) {
+        goto err;
+    }

     $first = fread($handle, 64);
     if ($first === false) {
     $first = fread($handle, 64);
     if ($first === false) {

-        return false;
+        goto err;
+    }
+    if (fseek($handle, $size < 64 ? 0 : $size - 64) == -1) {
+        goto err;

     }
     }

-    fseek($handle, $size < 64 ? 0 : $size - 64);

     $last = fread($handle, 64);
     $last = fread($handle, 64);

+    if ($last === false) {
+        goto err;
+    }
+    $out = md5($first . $last . $size);
+    err:

     fclose($handle);
     fclose($handle);

-    return md5($first . $last . $size);
+    return $out;

 }
 
 /**
 }
 
 /**