Check return value of `rename()` after encryption

diff --git a/lib/functions.php b/lib/functions.php
index c42293bcdcba3dfa2e35aa8ad416ea29a7c4c64b..805b958723aa6565148c397ccf5849b2709abbd2 100644 (file)
--- a/lib/functions.php
+++ b/lib/functions.php
@@ -460,8 +460,9 @@ function jirafeau_upload($file, $one_time_download, $key, $time, $ip, $crypt, $l
     if ($crypt == true && extension_loaded('sodium') == true) {
         $crypt_key = jirafeau_encrypt_file($file['tmp_name'], $file['tmp_name'].'crypt');
         if (strlen($crypt_key) > 0) {
     if ($crypt == true && extension_loaded('sodium') == true) {
         $crypt_key = jirafeau_encrypt_file($file['tmp_name'], $file['tmp_name'].'crypt');
         if (strlen($crypt_key) > 0) {

-            $crypted = true;
-            rename($file['tmp_name'].'crypt', $file['tmp_name']);
+            if (rename($file['tmp_name'].'crypt', $file['tmp_name']) === true) {
+                $crypted = true;
+            }

         }
     }
 
         }
     }
 


@@ -1145,11 +1146,11 @@ function jirafeau_async_end($ref, $code, $crypt, $link_name_length, $file_hash_m
     $crypted = false;
     $crypt_key = '';
     if ($crypt == true && extension_loaded('sodium') == true) {
     $crypted = false;
     $crypt_key = '';
     if ($crypt == true && extension_loaded('sodium') == true) {

-        //$crypt_key = jirafeau_encrypt_file($p, $p);

         $crypt_key = jirafeau_encrypt_file($p, $p.'.crypt');
         if (strlen($crypt_key) > 0) {
         $crypt_key = jirafeau_encrypt_file($p, $p.'.crypt');
         if (strlen($crypt_key) > 0) {

-            $crypted = true;
-            rename($p.'.crypt', $p);
+            if (rename($p.'.crypt', $p) === true) {
+                $crypted = true;
+            }

         }
     }
 
         }
     }